rsc-c icon indicating copy to clipboard operation
rsc-c copied to clipboard

Added multiple keyboard button positions and mobile menu text string with multiple positions

Open ipkpjersi opened this issue 1 year ago • 4 comments

Technically this may not be necessary, and I can understand not wanting it, and I promise I won't be offended if you don't want this - but I think it's actually really good and worth having.

Here are some examples of the menu text string positioning: Top:

Bottom:

Here are some examples of the keyboard button positioning: Left:

Top:

Right:

ipkpjersi avatar May 09 '24 02:05 ipkpjersi

FPS should be moved to the right in the second example to match legacy mudclients

alarixnia avatar May 09 '24 13:05 alarixnia

It already is on the right in desktop mode fwiw, I'm not sure why it isn't in mobile mode. There might have been a specific reason for it, I've found that's usually the case for most things I've found that are different in the mobile mode.

ipkpjersi avatar May 09 '24 13:05 ipkpjersi

I've not changed the FPS display for now as we could always change that in the future if we really needed to, but I did reposition the menu text when FPS is displaying versus not.

FPS displaying: Screenshot_2024-05-09-12-59-07-81_40deb401b9ffe8e1df2f1cc5ba480b12

FPS not displaying: Screenshot_2024-05-09-12-59-18-66_40deb401b9ffe8e1df2f1cc5ba480b12

I think this might be good to go as is now, as long as we do want these features I added. I've tested this PR pretty heavily and it seems to work perfectly for me.

ipkpjersi avatar May 09 '24 17:05 ipkpjersi

FPS should be moved to the right in the second example to match legacy mudclients

i think i moved it there since the UI was moved to the right, and FPS would often be obscured if a tab was open

misterhat avatar May 15 '24 00:05 misterhat