Luc Grosheintz

Results 154 comments of Luc Grosheintz

Definitely broken. For example libsonata tests will assert that something throws and the HDF5 diagnostics are printed despite the exception being handled. ``` test_get_inexistant_population (test_reports.TestElementReportReader.test_get_inexistant_population) ... HDF5-DIAG: Error detected in...

Here's a sketch of how we'd need to reorganize the header for the first approach: https://github.com/BlueBrain/HighFive/pull/892

> A thing to discuss is if you want to include H5Easy implemenations for Eigen, Boost, xtensor, openCV deeper in the core or not. Yes, this is one of the...

Regarding Style. I much prefer splitting definition and declaration. However, the point isn't cosmetic. If one's unlucky and one needs to change which files includes which other files, then HighFive...

A prime example why we need a relatively unexciting version 3.0.0 that just fixes the way dependencies are handled, fixes the CMake and doesn't break too much else. Moreover, it...

> if I've read everything correctly, splitting definitions and declarations will mean that HighFive will no longer be a header-only library, right? HighFive will continue to be a header only...

This allows us to do `xt::xarray`: #976

Marked as `v3` since it requires changes to the internal `inspector`. Given how close we are to `v3` and that users have touch this internal detail to add new containers,...