noisy icon indicating copy to clipboard operation
noisy copied to clipboard

Feature request: split config file

Open acyanic opened this issue 6 years ago • 3 comments

could this have the config file split into separate parts, eg

  1. config.json for the timing parameters
  2. rooturl.json for the root urls
  3. blacklisted.json for blacklisted urls
  4. useragent.json for the user agents a little easier to manage special cases eg testing scenarios or personal preferences

acyanic avatar Aug 13 '18 16:08 acyanic

Have a look at the branch https://github.com/Arduous/noisy/commits/featMultipleConfFiles Provided that you have properly split the config json files, it should be run with python noisy.py --config config.json --config blacklisted.json --config rooturl.json --config useragent.json If it works for you, I'll open a pull request

Arduous avatar Sep 01 '18 23:09 Arduous

Sorry am on holiday until oct. This helps but makes the command line clunky. Although ok from a script. Can json files be hierarchical ? so a master json has links to sub json files? Andy

On Sun, 2 Sep 2018, 02:00 Samuel Progin, [email protected] wrote:

Have a look at the branch https://github.com/Arduous/noisy/commits/featMultipleConfFiles Provided that you have properly split the config json files, it should be run with python noisy.py --config config.json --config blacklisted.json --config rooturl.json --config useragent.json If it works for you, I'll open a pull request

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/1tayH/noisy/issues/17#issuecomment-417893101, or mute the thread https://github.com/notifications/unsubscribe-auth/AoJJAJvDAdlBPAoxILTSUMLfn9L0pMbtks5uWxGYgaJpZM4V6y3G .

acyanic avatar Sep 11 '18 10:09 acyanic

It would be definitely doable.

The solution I proposed is altering very slightly the existing code base, using standard library functionalities.

I think (I would be happy to be proven false) that having config files definition within the main config file would require the addition of some json custom parsing logic. Let's see what @1tayH thinks if this functionality worth the complexity.

Arduous avatar Sep 11 '18 13:09 Arduous