Yury Selivanov comments

Results 403 comments of


                                            Yury Selivanov

implement Socket.setsockopt()

NODELAY should be set by default btw.

implement Socket.setsockopt()

Well, asyncio in Python 3.6 (and 3.5.3) sets `NODELAY` by default and so should we. It's really up to those who use advanced TCP settings to workaround that.

implement Socket.setsockopt()

Moreover, I hope we can use (eventually) vectorized writes in `tokio.Transport.write()` and `.writelines()`, which should cover use cases for `CORK`.

Test tokio with other libraries

Does tokio create its own rust Tasks? Why not Futures instead?

asyncio.Task.current_task() returns None

Yes, we do, after I finish on my current PEP, I'll switch to working on a PEP for asyncio improvements in 3.7. `loop.current_task()` will be a part of it.

Call for aiopg maintainer

I'd at least consider deprecating the project in favour of asyncpg.

Response parser requires support for HEAD responses without body

I don't have time to work on this, unfortunately. If you want you can submit a PR along with brief explanation/motivation and functional tests. @elprans and I would be happy...

sys.exit() caught in async event loop exception handler

> because in that case the handler isn't getting called from the Task \_\_del__ It's possible to fix -- see the attached future.patch. And perhaps this should be fixed in...

sys.exit() caught in async event loop exception handler

I see your points, but we're talking about BaseExceptions here -- KeyboardInterrupt, SystemExit etc. Those things usually mean that the program has to crash.

sys.exit() caught in async event loop exception handler

Trapping those exceptions in \_\_del__ isn't good. Another way to address this would be to at least modify call_exception_handler to log when an exception handler raises a BaseException error.