developer-portfolio icon indicating copy to clipboard operation
developer-portfolio copied to clipboard

Published 20 hours ago • verified publisher icon 1hanzla100

added dark theme support

Open amirrezaDev1378 opened this issue 1 year ago • 2 comments

I have added simple functionality to switch themes.

amirrezaDev1378 avatar Sep 20 '22 14:09 amirrezaDev1378

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
developer-portfolio ✅ Ready (Inspect) Visit Preview Sep 23, 2022 at 7:12AM (UTC)

vercel[bot] avatar Sep 20 '22 14:09 vercel[bot]

@amirrezaDev1378 Found Few Bugs. need to fix them

1hanzla100 avatar Sep 21 '22 20:09 1hanzla100

@1hanzla100 What bugs do you found? Can you give me a list please?

amirrezaDev1378 avatar Sep 22 '22 08:09 amirrezaDev1378

@1hanzla100 What bugs do you found? Can you give me a list please?

Iconify icons not loading Icon button for dark switch In dark mode imporve color contrast

1hanzla100 avatar Sep 22 '22 08:09 1hanzla100

@1hanzla100 Ok, I will fix these until the next 24 hours

amirrezaDev1378 avatar Sep 22 '22 08:09 amirrezaDev1378

Iconify is working correctly for me now, although I suggest switching to React icons package: https://react-icons.github.io/react-icons/

amirrezaDev1378 avatar Sep 23 '22 07:09 amirrezaDev1378

@amirrezaDev1378 we have to use Iconify because most of the development related icons are only available on iconify

1hanzla100 avatar Sep 23 '22 14:09 1hanzla100

Do you need me to do something else?

amirrezaDev1378 avatar Oct 11 '22 16:10 amirrezaDev1378

@amirrezaDev1378 There are few this that need to be improved.

  1. In Light Mode of greeting text is black that should be white
  2. In Dark Mode Background of Greeting is Comparatively lighter
  3. In Dark The Experience & Contact section remain same that need to be fixed
  4. In Dark mode Cards bg Should be black as well with light grey shadow
  5. Dark Model bg color is too much dark make it #171c28

1hanzla100 avatar Oct 11 '22 16:10 1hanzla100