Abhishek Patidar

Results 48 comments of Abhishek Patidar

@brocksam As the code_quality test fails, should we make changes given in the details of the [test](https://github.com/sympy/sympy/actions/runs/4332502880/jobs/7565039765).

> The `code_quality` job is failing because flake8 with E711 and E712 is reporting violations. Either the files with the violations should be fixed because they are violations, or if...

> Is every single one of those instances a situation where we should be testing equality and not identity against the built-in singleton values? If so they we can add...

I think it will be the right way to solve this ``` python >>> solve(x*y+1, x, y) ⎡⎛-1 ⎞⎤ ⎢⎜───, y⎟⎥ ⎣⎝ y ⎠⎦ ```

You don't need to create new pull requests for the new commits as you already have a pull request #24748 for the same issue.

@oscarbenjamin Is something that should also be changed to fix the brackets ? ``` >>> print(1/UnevaluatedExpr(sqrt(pi))) 1/(sqrt(pi)) ```

> @oscarbenjamin Is something that should also be changed to fix the brackets ? > > ``` > >>> print(1/UnevaluatedExpr(sqrt(pi))) > 1/(sqrt(pi)) > ``` @oscarbenjamin

> I don't know the printing code so well so I'm not sure how to handle brackets. Is it necessary to fix the brackets although this PR fixes issue #19435...

> > I don't know the printing code so well so I'm not sure how to handle brackets. > > Is it necessary to fix the brackets although this PR...

@sylee957 This test is falling `test / tests1 (3.12.0-alpha - 3.12, false) (pull_request)` is it unrelateable ?