Add features for other tls types
This is a continuation of https://github.com/1c3t3a/rust-socketio/pull/465 that was originally done by @ctrlaltf24.
My company has been using that branch with a few minor improvements. I just got the tests passing by changing how the certificates and keys are generated so that rustls will accept localhost in a secure connection.
are there any update for this PR? I would like to use this branch in my project, is this "stable"?
are there any update for this PR? I would like to use this branch in my project, is this "stable"?
Yes, this is stable. It will only have requested changes needed to make requested fixes (if that ever happens)
You can also use the nextdata-tech:feat-add-features-for-other-tls-types branch that has the same fixes, just not with the tests passing
is this PR ready for review?
It works very well on my project. @1c3t3a, can it be reviewed for merging?
It's a very important feature...
This is ready for review, unless you want it broken up, which I can do, but this is the effect of making a change and having a couple of dependency bumps and a couple of bug fixes over time. More that 60% of the code would remain on this pr if I did break it up.
I'd also love to see this one merged.
What's the hold up?
Could this be extended to build without tls at all?
I don't need tls in my project and it is a nuisance to cross build (ring dependency fails to cross compile with musl).