rust-socketio icon indicating copy to clipboard operation
rust-socketio copied to clipboard

feat: add features for other tls types

Open ctrlaltf24 opened this issue 1 year ago • 1 comments

Turned out to be rather easy due to all tls being handled by our dependencies.

Don't love the _fallback-tls feature, however with it we can use cargo-all-features, which helps reduce feature related bugs.

Downside of cargo-all-features is it takes a long time to execute.

Fixes: #407, #366

cc: @GaryCraft @tyilo @rageshkrishna

ctrlaltf24 avatar Sep 20 '24 02:09 ctrlaltf24

Ran out of time. Need to still resolve the CI issue where for some reason the certificates are showing up as invalid hostnames.

If someone could fix that bug, this would be ready to go.

ctrlaltf24 avatar Sep 20 '24 04:09 ctrlaltf24

any update for this PR?

shenjackyuanjie avatar Mar 13 '25 15:03 shenjackyuanjie

why was this PR closed?

kajogo777 avatar Jul 15 '25 10:07 kajogo777

why was this PR closed?

Because it got superseeded by #497

tyilo avatar Jul 15 '25 10:07 tyilo