bsl-language-server icon indicating copy to clipboard operation
bsl-language-server copied to clipboard

New Crowdin updates

Open nixel2007 opened this issue 2 months ago • 3 comments

Summary by CodeRabbit

  • Documentation
    • Updated multiple diagnostic and contributing documentation files with localization enhancements, including removal of language qualifiers from source references.
    • Reformatted section headers and example labels for consistency (e.g., "Description" to "Diagnostics description," "Incorrect" to "Wrong").
    • Adjusted code samples with localized translations and formatting improvements.
    • Enhanced source citations and adjusted documentation structure for better clarity.

✏️ Tip: You can customize this high-level summary in your review settings.

nixel2007 avatar Dec 15 '25 13:12 nixel2007

Walkthrough

This PR updates documentation across contributing guides and diagnostic documentation, making formatting refinements, removing language qualifiers from source references, standardizing example labels (Incorrect→Wrong, Correct→Right), updating section headers, and localizing content to Russian where applicable.

Changes

Cohort / File(s) Summary
Contributing Guides
docs/en/contributing/DiagnostcAddSettings.md, docs/en/contributing/DiagnosticDevWorkFlow.md, docs/en/contributing/DiagnosticExample.md, docs/en/contributing/DiagnosticStructure.md, docs/en/contributing/DiagnosticTypeAndSeverity.md, docs/en/contributing/EventsApi.md, docs/en/contributing/StyleGuide.md
Minor formatting fixes, whitespace adjustments, wording updates, and Russian section header translations (e.g., "Null values" → "Обработка null")
Diagnostic Docs – Source Reference Cleanup
docs/en/diagnostics/CachedPublic.md, docs/en/diagnostics/CanonicalSpellingKeywords.md, docs/en/diagnostics/CodeBlockBeforeSub.md, docs/en/diagnostics/CodeOutOfRegion.md, docs/en/diagnostics/CommentedCode.md, docs/en/diagnostics/CommonModuleMissingAPI.md, docs/en/diagnostics/CompilationDirectiveNeedLess.md, docs/en/diagnostics/DeprecatedAttributes8312.md, docs/en/diagnostics/DeprecatedMethods8310.md, docs/en/diagnostics/DeprecatedMethods8317.md, docs/en/diagnostics/DeprecatedMessage.md, docs/en/diagnostics/DeprecatedMethodCall.md, docs/en/diagnostics/DeprecatedTypeManagedForm.md, docs/en/diagnostics/DuplicateRegion.md, docs/en/diagnostics/DuplicateStringLiteral.md, docs/en/diagnostics/EmptyRegion.md, docs/en/diagnostics/ExportVariables.md, docs/en/diagnostics/FormDataToValue.md, docs/en/diagnostics/FullOuterJoinQuery.md, docs/en/diagnostics/FunctionNameStartsWithGet.md, docs/en/diagnostics/GetFormMethod.md, docs/en/diagnostics/IncorrectUseLikeInQuery.md, docs/en/diagnostics/IncorrectUseOfStrTemplate.md, docs/en/diagnostics/InvalidCharacterInFile.md, docs/en/diagnostics/IsInRoleMethod.md, docs/en/diagnostics/LineLength.md, docs/en/diagnostics/MethodSize.md, docs/en/diagnostics/MissingParameterDescription.md, docs/en/diagnostics/MissingReturnedValueDescription.md, docs/en/diagnostics/MissingVariablesDescription.md, docs/en/diagnostics/MultilingualStringHasAllDeclaredLanguages.md, docs/en/diagnostics/NonExportMethodsInApiRegion.md, docs/en/diagnostics/NonStandardRegion.md, docs/en/diagnostics/NumberOfValuesInStructureConstructor.md, docs/en/diagnostics/OneStatementPerLine.md, docs/en/diagnostics/OrdinaryAppSupport.md, docs/en/diagnostics/PairingBrokenTransaction.md, docs/en/diagnostics/SelectTopWithoutOrderBy.md, docs/en/diagnostics/SelfInsertion.md, docs/en/diagnostics/SetPermissionsForNewObjects.md, docs/en/diagnostics/SpaceAtStartComment.md, docs/en/diagnostics/StyleElementConstructors.md, docs/en/diagnostics/TimeoutsInExternalResources.md, docs/en/diagnostics/TryNumber.md
Removed language qualifiers (RU) from source reference link text, replaced Russian source labels with English equivalents, updated section headers (Sources→Reference), and adjusted link anchors and URLs for consistency
Diagnostic Docs – Header & Label Standardization
docs/en/diagnostics/BadWords.md, docs/en/diagnostics/CommonModuleInvalidType.md, docs/en/diagnostics/CommonModuleNameFullAccess.md, docs/en/diagnostics/CommonModuleNameGlobalClient.md, docs/en/diagnostics/CommonModuleNameWords.md, docs/en/diagnostics/CreateQueryInCycle.md, docs/en/diagnostics/DataExchangeLoading.md, docs/en/diagnostics/DeletingCollectionItem.md, docs/en/diagnostics/DeprecatedCurrentDate.md, docs/en/diagnostics/FieldsFromJoinsWithoutIsNull.md, docs/en/diagnostics/ForbiddenMetadataName.md, docs/en/diagnostics/FunctionOutParameter.md, docs/en/diagnostics/GlobalContextMethodCollision8312.md, docs/en/diagnostics/MissingCodeTryCatchEx.md, docs/en/diagnostics/MissingTempStorageDeletion.md, docs/en/diagnostics/MissingTemporaryFileDeletion.md, docs/en/diagnostics/MultilingualStringUsingWithTemplate.md, docs/en/diagnostics/NestedFunctionInParameters.md, docs/en/diagnostics/NestedStatements.md, docs/en/diagnostics/NestedTernaryOperator.md, docs/en/diagnostics/NumberOfParams.md, docs/en/diagnostics/ParseError.md, docs/en/diagnostics/QueryNestedFieldsByDot.md, docs/en/diagnostics/QueryParseError.md, docs/en/diagnostics/QueryToMissingMetadata.md, docs/en/diagnostics/SameMetadataObjectAndChildNames.md, docs/en/diagnostics/SeveralCompilerDirectives.md, docs/en/diagnostics/ServerCallsInFormEvents.md, docs/en/diagnostics/ServerSideExportFormMethod.md, docs/en/diagnostics/TempFilesDir.md, docs/en/diagnostics/TernaryOperatorUsage.md
Standardized example labels (Incorrect→Wrong, Correct→Right/Good), updated section headers (Description→Diagnostics description), adjusted code block formatting and indentation, and minor wording refinements
Diagnostic Docs – Content Expansion & Localization
docs/en/diagnostics/CrazyMultilineString.md, docs/en/diagnostics/DenyIncompleteValues.md, docs/en/diagnostics/DisableSafeMode.md, docs/en/diagnostics/DoubleNegatives.md, docs/en/diagnostics/ExecuteExternalCode.md, docs/en/diagnostics/ExternalAppStarting.md, docs/en/diagnostics/FileSystemAccess.md, docs/en/diagnostics/InternetAccess.md, docs/en/diagnostics/LogicalOrInJoinQuerySection.md, docs/en/diagnostics/LogicalOrInTheWhereSectionOfQuery.md, docs/en/diagnostics/MagicDate.md, docs/en/diagnostics/MissedRequiredParameter.md, docs/en/diagnostics/MissingCommonModuleMethod.md, docs/en/diagnostics/MultilineStringInQuery.md, docs/en/diagnostics/PrivilegedModuleMethodCall.md, docs/en/diagnostics/ProtectedModule.md, docs/en/diagnostics/RefOveruse.md, docs/en/diagnostics/ReservedParameterNames.md, docs/en/diagnostics/RewriteMethodParameter.md, docs/en/diagnostics/ScheduledJobHandler.md, docs/en/diagnostics/SetPrivilegedMode.md, docs/en/diagnostics/TransferringParametersBetweenClientAndServer.md, docs/en/diagnostics/DuplicatedInsertionIntoCollection.md
Added Description/Examples/Sources sections, expanded documentation with Russian translations and bilingual content, updated code examples with localized identifiers, added bullet lists and explanatory notes, and restructured narrative flows

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25–35 minutes

  • High volume: 100+ files changed with mostly repetitive formatting and localization updates
  • Low heterogeneity: Consistent patterns (label standardization, RU removal, header updates) across many files reduce reasoning per file
  • Moderate complexity: Mix of simple label/formatting changes and some substantive content expansions and example updates requiring careful verification

Areas requiring extra attention:

  • Diagnostic files with expanded content (DisableSafeMode.md, SetPrivilegedMode.md, LogicalOrInJoinQuerySection.md, TransferringParametersBetweenClientAndServer.md) – verify localization accuracy and clarity
  • Source reference updates – ensure all URL targets remain correct and no links are broken
  • Example code blocks with Russian localization – validate syntax correctness and alignment with original intent

Possibly related PRs

Suggested labels

hacktoberfest-accepted

Poem

🐰 Whiskers twitching with delight,
Docs now sparkle, clean and bright!
Labels fixed from Wrong to Right,
Russian touches shine tonight—
A hundred files, all holding tight!

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'New Crowdin updates' is vague and generic, using a non-descriptive term that doesn't convey specific information about the changeset's main purpose. Consider using a more descriptive title that explains what type of updates were made, such as 'Update documentation translations via Crowdin' or 'Localization updates for diagnostic documentation'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
  • [ ] Commit unit tests in branch l10n_develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Dec 15 '25 13:12 coderabbitai[bot]

Test Results

0 files   - 2 700  0 suites   - 2 700   0s ⏱️ - 48m 7s 0 tests  - 1 011  0 ✅  - 1 011  0 💤 ±0  0 ❌ ±0  0 runs   - 9 099  0 ✅  - 9 099  0 💤 ±0  0 ❌ ±0 

Results for commit 35923f8f. ± Comparison against base commit 321bdf99.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Dec 15 '25 15:12 github-actions[bot]