op-scim-helm icon indicating copy to clipboard operation
op-scim-helm copied to clipboard

SCIM bridge fails to start if tlsDomain is not set to null.

Open gothrek22 opened this issue 1 year ago • 1 comments

Newest version of the chart (2.10.5), newest version of the scim bridge (2.8.4).

I've set values.yml as below: image

In theory this should set the OP_TLS_DOMAIN env var to null which disables the Let's Encrypt flow. Thing is, that due to condition here: https://github.com/1Password/op-scim-helm/blob/c052648748bc54081b2ae066b82bf7c976651579/charts/op-scim-bridge/templates/deployment.yaml#L139

null is evaluated to false, env is not rendered, scim bridge gets to CrashLoopBackoff, as it tries to do Let's Encrypt dance when it shouldn't.

So either:

  • disable the check and always set the var with some sane default (i.e. null)
  • change the behavior of the scim binary to NOT do the Let's Encrypt dance unless explicitly told to do so.

gothrek22 avatar Oct 06 '23 18:10 gothrek22