load-secrets-action icon indicating copy to clipboard operation
load-secrets-action copied to clipboard

Upgrade to Node.js 22

Open gskierk opened this issue 11 months ago • 1 comments

Node.js 22 is LTS. Should we update .yml files to use 22 instead of 20?

gskierk avatar Dec 29 '24 02:12 gskierk

Hey @gskierk! 👋🏻

Thank you for asking this question and I appreciate your initiative to keep our integrations up-to-date. It would be useful to upgrade the action to use Node 22 and we even encourage external contribution on this (even you).

The goal we have when making such upgrades is to avoid making lots of major releases. Currently the GitHub guidelines don't seem to suggest switching to Node 22 just yet, therefore I don't think it is the right time to upgrade now. Once they've updated their guidelines to comfortably switch to that version, then you're more than welcome to bring this change to this action as well.

Here are a couple of additional things to consider when upgrading the Node version:

  • Upgrading the Node version in a GitHub action usually means making a new major release. That is done to account for any potential breaking changes that can come from upgrading the Node version. This happens even though the action itself doesn’t have breaking changes.
  • Javascript-written GitHub Actions currently default to Node 20. It's not mentioned that Node 22 is fully supported yet. When they will upgrade to defaulting to Node 22, then it's worth making that effort.
  • The active support for Node.js 20 ended 2 months ago, but it still receives security patches for the next 1 year and 4 months.
  • There’s an effort made by the community to rewrite the GitHub Action into a pure Javascript action which leverages the SDKs. We want to make this backwards-compatible, and updating the Node version at this time would add extra complications.

Let me know if you have any further questions about this. 😄

edif2008 avatar Dec 31 '24 18:12 edif2008