install-cli-action icon indicating copy to clipboard operation
install-cli-action copied to clipboard

Installing 1Password CLI version: v

Open roryabraham opened this issue 8 months ago • 5 comments

We've only seen this happen once as far as I know, so I'm not sure the conditions that cause it. 1Password/install-cli-action can randomly fail with:

Installing 1Password CLI version: v
curl: (22) The requested URL returned error: 404

Maybe just a random network error causes this to fail: https://github.com/1Password/install-cli-action/blob/main/install-cli.sh#L18

Perhaps wrap it with a retry with exponential backoff?

roryabraham avatar Feb 27 '25 23:02 roryabraham

Hmmm, yeah I think you're on the right track that if that curl comes up empty we have just the v.

I'm a bit surprised though that a network error wouldn't lead the entire script to fail though, even before getting around to printing that "Installing 1Password CLI version: v" line (source), since it sets set -e at the top (source).

According to set -e docs:

Exit immediately if a pipeline, which may consist of a single simple command, a list, or a compound command returns a non-zero status. (source)

Subshells spawned to execute command substitutions inherit the value of the -e option from the parent shell. (source)

SimonBarendse avatar Feb 28 '25 13:02 SimonBarendse

Just encountered the same thing and can confirm it is caused by a network issue:

Installing 1Password CLI version: v
curl: (28) SSL connection timeout

I ran it on a runner without network connectivity. I'm calling the action without specifying a version, which is causing the version string to be a single v

https://github.com/1Password/install-cli-action/blob/36d945beb11316f8b9497501fed0862317932685/install-cli.sh#L18

nopcorn avatar Mar 04 '25 01:03 nopcorn

I was about to propose a change with --connect-timeout on the curl statement, but I'm not sure overriding user-set system timeout is a good idea. In my case I waited around for 10 minutes before the action failed and at least it provided me with the curl error.

This might be a nofix.

nopcorn avatar Mar 04 '25 12:03 nopcorn

Hi this started to happen in our CI builds as well out of the sudden. We are using https://www.blacksmith.sh/ as our CI runners

guidomb avatar Apr 14 '25 15:04 guidomb

This should be tackled by https://github.com/1Password/install-cli-action/issues/17

volodymyrZotov avatar Jul 22 '25 19:07 volodymyrZotov