1Panel icon indicating copy to clipboard operation
1Panel copied to clipboard

fix: Remove `proxy_cache ` from the global config to prevent it from being enabled for sites that don't need caching.

Open Anyexyz opened this issue 11 months ago โ€ข 5 comments
trafficstars

What this PR does / why we need it?

Fix the problem in https://bbs.fit2cloud.com/t/topic/8868.

Summary of your change

Removed proxy_cache from global cache configuration.

Please indicate you've done the following:

  • [x] Made sure tests are passing and test coverage is added if needed.
  • [x] Made sure commit message follow the rule of Conventional Commits specification.
  • [x] Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

Anyexyz avatar Dec 21 '24 14:12 Anyexyz

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot[bot] avatar Dec 21 '24 14:12 f2c-ci-robot[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign wanghe-fit2cloud for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

f2c-ci-robot[bot] avatar Dec 21 '24 14:12 f2c-ci-robot[bot]

่ฟ™ไธช้…็ฝฎๆ˜ฏ็ป™ๅไปฃ็ผ“ๅญ˜็”จ็š„๏ผŒๅŽปๆމไผšๅ‡บ้—ฎ้ข˜

zhengkunwang223 avatar Dec 21 '24 14:12 zhengkunwang223

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


This configuration is used for reverse generation caching. Removing it will cause problems.

wanghe-fit2cloud avatar Dec 21 '24 14:12 wanghe-fit2cloud

Based on the configuration of version v1, it seems more suitable to explicitly declare proxy_cache off for sites where caching is not enabled.

bh1xaq avatar Dec 21 '24 14:12 bh1xaq