gardens-ui icon indicating copy to clipboard operation
gardens-ui copied to clipboard

Remove useActions from many screens

Open Harthor opened this issue 3 years ago • 2 comments

We worked on this issue with @juliangnr90 We removed useActions from 8 screens. On each screen we receive only the necessary actions for the screen through props.

The only one we didn't remove is createProposalScreen because this is called from Home and Footer, with Home it's ok because it's already calling useActions, the problem is the footer component, which is called from MainView component and we are not sure which is the best way to call actions from that component.

We tested it for: RaiseDisputeScreens RemoveProposalScreens SignAgreementScreens SupportProposalScreens WrapTokenScreens

We will be able to test these in the next 48 hours I think, we left a proposal challenged and a proposal supported in the test dao. ExecuteProposalScreens SettleProposalScreens

We don't know about ClaimRewardsScreens

Harthor avatar Sep 26 '21 22:09 Harthor

@Harthor is attempting to deploy a commit to the 1hive Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 26 '21 22:09 vercel[bot]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/1hive/honey-pot/CPeFU6qXAcPEuLXvXqD5KRBf5t5E
✅ Preview: https://honey-pot-git-fork-harthor-gardens-1hive.vercel.app

vercel[bot] avatar Sep 27 '21 22:09 vercel[bot]