identity-idp icon indicating copy to clipboard operation
identity-idp copied to clipboard

Published 20 hours ago • verified publisher icon 18F

Fix 500 error when handling unsafe redirects

Open mitchellhenke opened this issue 2 years ago • 2 comments

New Relic

Similar strategy as in #6682, and since this controller does not inherit from ApplicationController, we can make similar changes.

mitchellhenke avatar Aug 12 '22 17:08 mitchellhenke

LGTM! bonus points for a spec

I can add one for this route, but we do have the ApplicationController behavior covered here

mitchellhenke avatar Aug 12 '22 17:08 mitchellhenke

LGTM! bonus points for a spec

I can add one for this route, but we do have the ApplicationController behavior covered here

If it's easy, yes! It makes for a good regression case if we ever change/remove that behavior at the base class

zachmargolis avatar Aug 12 '22 17:08 zachmargolis