LG-13668: Stop reading "Document capture" in voice over on selfie capture.

[solipet]

🎫 Ticket

Link to the relevant ticket: LG-13668

🛠 Summary of changes

Removes the aria label for the capture dialog for selfie capture so a screen reader won't read "document capture"

📜 Testing Plan

With a screen reader on go to selfie capture. Before this fix, it reads "Document capture. Web dialog...". After this fix, "Web dialog..."

[aduth]

Will this be tested for accessibility impact or has the ticket been reviewed by an accessibility SME? I'm not sure I agree with the premise of how the ticket is written. Dialogs should (must, even!) be labelled.

Authors MUST provide an accessible name for a dialog, which can be done with the aria-label or aria-labelledby attribute.

https://www.w3.org/TR/wai-aria-1.2/#dialog

The dialog has either:

• A value set for the aria-labelledby property that refers to a visible dialog title.
• A label specified by aria-label.

https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/#wai-ariaroles,states,andproperties

Why it Matters Screen reader users are not able to discern the purpose of elements with role="dialog" or role="alertdialog" that do not have an accessible name.

https://dequeuniversity.com/rules/axe/4.9/aria-dialog-name

[solipet]

Will this be tested for accessibility impact or has the ticket been reviewed by an accessibility SME? I'm not sure I agree with the premise of how the ticket is written. Dialogs should (must, even!) be labelled.

Authors MUST provide an accessible name for a dialog, which can be done with the aria-label or aria-labelledby attribute.

We briefly discussed this and agree that it should have a label. This PR simply removes the label because it is incorrect and we don't yet have final copy/translations for a replacement. Is no label worse than an incorrect label?

[aduth]

Ah, I hadn't realized this was specifically for the selfie capture. I think it'd be nice to just address it once the replacement text is available, but no strong feelings since this isn't live for end-users anyways.

Do you have a link to the ticket for implementing the updated label?

[solipet]

Do you have a link to the ticket for implementing the updated label?

LG-13829

[aduth]

@solipet Do you know if this will be revisited soon? I see that LG-13829 is done, but unclear the status of the follow-on ticket LG-13668.

Should we close this pull request, since LG-13668 will likely go a different implementation direction anyways?

[solipet]

Agree this should be closed. Will follow up on status of LG-13668.