18f.gsa.gov icon indicating copy to clipboard operation
18f.gsa.gov copied to clipboard

Update team_members.csv

Open rrefoy opened this issue 1 year ago • 2 comments

Edited the URL that points to blog posts done by moi to be corrected to my current name.

https://18f.gsa.gov/author/rebecca-refoy-sidibe/

Pull request summary

Here's what I'm trying to do with this PR: Edited the URL that points to blog posts done by moi to be corrected to my current name.

https://18f.gsa.gov/author/rebecca-refoy-sidibe/ should be https://18f.gsa.gov/author/rebecca-refoy/

Reminder - please do the following before assigning reviewer

  • [ ] Update readme
  • [ ] For frontend changes, ensure design review
  • [ ] For content changes beyond typos, add Ron Bronson as a reviewer

And make sure that automated checks are ok

  • fix houndci feedback
  • ensure tests pass
  • federalist builds
  • no new SNYK vulnerabilities are introduced

rrefoy avatar Aug 23 '24 19:08 rrefoy

The tests/CI did not catch this but with this change, we get rebecca-refoy-sidibe is undefined messages in the output, because that author becomes "unknown" when 11ty processes the blog posts. So I think we'll have to change the author front matter in the relevant blog posts. I'm not too sure if we can do a redirect_from for authors. @beechnut do you know?

cantsin avatar Aug 23 '24 19:08 cantsin

@cantsin The last column of the CSV is redirect_from, so, you in fact can do that! It should autogenerate. Also, I'm surprised that the undefined author error didn't break the build — it should have. Let's open an issue soon.

@rrefoy I noticed that you only changed the slug — did you also want to change your display name?

beechnut avatar Aug 23 '24 23:08 beechnut

In my local environment, I tried adding a redirect from /author/rebecca-refoy-sidibe/ via the CSV file, but I don't see any evidence that the redirect_from values are being written into the front matter for the generated author pages. @beechnut if that's surprising I can capture a follow-up ticket to look into that (it's possible I'm also interpreting that logic incorrectly).

In any event, to avoid the undefined errors I think we do need to update the author slug to rebecca-refoy in all of the existing blog posts. I can push up that change myself sometime this week.

nateborr avatar Sep 18 '24 18:09 nateborr