18f.gsa.gov icon indicating copy to clipboard operation
18f.gsa.gov copied to clipboard

BUG Social link in the footer opening in the same tab

Open tmsagarofficial opened this issue 10 months ago • 1 comments

Expected Behavior

The social links in the footer should open in new tabs upon clicking them for the best user experience

Actual Behavior

But here these social links in the footer open in the same tab as the current tab making it a hindrance for the user experience as the user has to go back to the site and then proceed after using each social link.

Steps to reproduce the behavior

  1. Go to https://18f.gsa.gov
  2. Scroll till you see the footer of the website
  3. Observe that clicking on any of the social links makes it open in the same tab as the current tab. Image ref below: image

This issue is done when

This issue does not have any special triggering event.

PS: I would love to work on a fix for this issue and am open for discussion about the same too.

tmsagarofficial avatar Oct 21 '23 03:10 tmsagarofficial

Thanks for the ticket! For folks who are reviewing this, consider the accessibility implications before deciding how to address.

adunkman avatar Mar 01 '24 18:03 adunkman

Our accessibility experts have weighed in:

  • Its generally discouraged to open new windows or tabs.
  • The cases where it's recommended are for additional context information or if following the link would take the user away from a logged in session
  • If you are going to do it, there should be advanced warning (with alt text and an icon)
  • see: https://www.w3.org/TR/WCAG20-TECHS/G200.html

Neither of the cases where it is recommended for accessibility apply to these links, so we should probably leave it as it is.

peterrowland avatar Apr 09 '24 17:04 peterrowland

Okay , thanks for responding. Yeah maybe leaving it as it is feels right .

On Tue, Apr 9, 2024, 22:56 Peter Rowland @.***> wrote:

Our accessibility experts have weighed in:

  • Its generally discouraged to open new windows or tabs.
  • The cases where it's recommended are for additional context information or if following the link would take the user away from a logged in session
  • If you are going to do it, there should be advanced warning (with alt text and an icon)
  • see: https://www.w3.org/TR/WCAG20-TECHS/G200.html

Neither of the cases where it is recommended for accessibility apply to these links, so we should probably leave it as it is.

— Reply to this email directly, view it on GitHub https://github.com/18F/18f.gsa.gov/issues/3775#issuecomment-2045739055, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2MYN4PIF26H5FL6WNOFKODY4QQEHAVCNFSM6AAAAAA6J3IAUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBVG4ZTSMBVGU . You are receiving this because you authored the thread.Message ID: @.***>

tmsagarofficial avatar Apr 09 '24 17:04 tmsagarofficial