eleventy icon indicating copy to clipboard operation
eleventy copied to clipboard

Swap globber to use `fs.glob` or `fs.globSync`

Open zachleat opened this issue 8 months ago • 6 comments

https://nodejs.org/api/fs.html#fspromisesglobpattern-options

Available in Node 22+ ~~and is currently an Experimental API.~~

Stable in Node v24.0.0, v22.17.0

Follow up to #3167 and #3680

zachleat avatar Apr 14 '25 21:04 zachleat

~~By default this repo closes enhancement request issues and places them in a queue for folks to upvote. We do this to avoid a large build-up of open issues. We got this idea from the lodash project.~~

~~Don’t forget to upvote the first comment with 👍 to register your vote! You can view the current enhancement backlog.~~

zachleat avatar Apr 14 '25 21:04 zachleat

Do you mind to add a comment on why this was closed as „not planned”? I'm confused because it is part of the milestone at the same time.

Ryuno-Ki avatar Apr 15 '25 15:04 Ryuno-Ki

The current GitHub options for closed issues are: Completed, Duplicate, or Not Planned. Not planned is the most accurate of these choices, unfortunately — even though it is planned 😭

zachleat avatar Apr 15 '25 17:04 zachleat

As I think I've mentioned before, I agree with @Ryuno-Ki that this is a confusing set up. There are better ways to approach issue management than the "lodash" style. (Lodash, fwiw, might not be such a great inspiration? I think it is pretty much unmaintained these days. We could look around at other, modern, large projects like Vite or something and see how they handle large issue volumes if that is the concern.) Requiring upvotes and adding a needs-votes label is fine, closing it seems unnecessary.

The current GitHub options for closed issues are: Completed, Duplicate, or Not Planned. Not planned is the most accurate of these choices, unfortunately — even though it is planned 😭

I think this only serves to show that GitHub's issues aren't designed for this kind of workflow

In particular https://github.com/11ty/eleventy/issues/461 has been brought up as especially confusing because it is marked as "completed"/closed and yet also a pinned issue.

uncenter avatar Apr 16 '25 11:04 uncenter

Yeah… I understand. I think you’re right that this issue specifically is separate from the queue — it is milestoned to v4 now. The voting queue is more of a nicer “No-by-default” answer to enhancements that may not (and probably won’t) make the cut — and as such I really don’t want those to clutter the open issues. I wish GitHub had a better workflow for this use case but it doesn’t! I’m interested in other ideas that don’t result in a big ol’ list of enhancement requests sitting as open issues

zachleat avatar Apr 16 '25 17:04 zachleat

Should we open an issue on discussing issue management specifically? Would love to hear your thoughts but I don't want to fill up this issue any more than we already have 😅

uncenter avatar Apr 16 '25 18:04 uncenter