mame icon indicating copy to clipboard operation
mame copied to clipboard

Automatically stops recording of the previous VGM file when switching tracks.

Open denjhang opened this issue 2 years ago • 9 comments

I found this feature to be somewhat incomplete if it just started automatically. I want to automatically start recording VGM when a track is played when there are many midi files in a midi playlist, and automatically stop recording the previous VGM and start recording a new VGM file when switching tracks.

denjhang avatar Jun 18 '22 10:06 denjhang

Implemented the feature. Could you please check this ? @denjhang

https://github.com/110-kenichi/mame/releases/tag/v4.1.2.0

110-kenichi avatar Jul 20 '22 10:07 110-kenichi

Thank you, I'm recording the Goldberg Variations in version YM2151.

denjhang avatar Jul 20 '22 13:07 denjhang

I recorded 10 Goldberg Variations in a row and found that MAmi was crashing.

denjhang avatar Jul 20 '22 14:07 denjhang

Thank you for reporting! Can you share the midi file to reproduce the issue ? @denjhang

110-kenichi avatar Jul 21 '22 10:07 110-kenichi

Looks like a problem with my operation. I clicked the VGM record button first, then clicked the button to automatically record VGM, and then played the midi file. Bach.Goldberg.Variations.zip

denjhang avatar Jul 21 '22 11:07 denjhang

If I just click the button that automatically records the VGM, and then play the midi file, there is no problem (seems to be the case).

denjhang avatar Jul 21 '22 11:07 denjhang

Hmm. Can't reproduce. Can you reproduce the issue everytime? @denjhang

110-kenichi avatar Jul 22 '22 11:07 110-kenichi

At present, this problem is difficult to reproduce and belongs to a small probability event, so ignore it for the time being.

denjhang avatar Jul 22 '22 11:07 denjhang

I see. I will investigate a bit.

110-kenichi avatar Jul 22 '22 12:07 110-kenichi