wp-local-docker-v2 icon indicating copy to clipboard operation
wp-local-docker-v2 copied to clipboard

Redis

Open jamesmorrison opened this issue 5 years ago • 3 comments

Description of the Change

Adding Redis object caching support

Alternate Designs

Benefits

Many projects are hosted on platforms using Redis rather than Memcached, adding support for Redis allows the object cache to be utilised and tested locally as well as on staging environments prior to a production release.

Possible Drawbacks

Verification Process

This was tested on a project locally, in conjunction with WP Redis and a standard configuration and showed the object cache was functioning correctly:

$redis_server = array(
	'host' => 'redis',
	'port' => 6379,
);

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my change.
  • [ ] All new and existing tests passed.

Applicable Issues

Changelog Entry

Added Redis Object Cache support.

jamesmorrison avatar May 18 '20 16:05 jamesmorrison

I understand that redis is important for some projects, but I think this PR is not ready for the release yet because we can't accept it as is. If we want to add redis support, we need to modify the create command to ask users which caching service they want to use and let them select between memcached and redis. @jamesmorrison do you mind to rebase your branch against release/2.8.0 and implement it?

eugene-manuilov avatar Aug 27 '20 13:08 eugene-manuilov

@jamesmorrison are you able to help work through any of the 6 items that Eugene noted in his prior review comment?

jeffpaul avatar May 19 '21 15:05 jeffpaul

👋🏻 @jeffpaul - Yes I'd like to finish this up, it didn't slip my mind but I haven't found time to work on this yet.

I've recently completed a Node CLI course; and have been exploring Docker / Docker Compose a lot recently so it would be nice to see this through!

jamesmorrison avatar May 19 '21 17:05 jamesmorrison