windows-azure-storage
windows-azure-storage copied to clipboard
10up
Plugin Compatibility Testing With Wordpress 6.8-RC2
Description of the Change
Closes #263
How to test the Change
Follow the critical flows to test the PR
Changelog Entry
Changed - Bump WordPress "tested up to" version 6.8.
Hi @jeffpaul , @vikrampm1, @dkotter
The plugin has been tested with an upcoming version of WordPress 6.8 RC-2 without any issues.
QA Status: PASS
Environment WordPress: 6.8-RC2 PHP: 8.2.23 Server: nginx Database: mysqli (Server: 8.0.35 / Client: mysqlnd 8.2.23) Browser: Version 134.0.6998.178 (Official Build) (64-bit) Theme: Twenty Twenty-Five Version: 1.1
Tested Plugin version: Microsoft Azure Storage for WordPress version Version 4.5.1
Plugin enabled SS:
@10up/open-source-practice e2e failures, perhaps the cypress-wp-utils bump to 0.6.0 will help but unsure if that'll resolve all the issues here?
Tests are failing due to some secrets not existing. Do we know if those have been changed recently? I see those secrets set on this repo but can't tell if those actually have a value set.
Just refreshed the repo secrets from what we have on record and re-ran the failed e2e jobs 🤞🏼
Whelp still seeing e2e tests. @rickalee any chance the secrets for our test Azure account have updated and need to be adjusted here?
In chatting with @rickalee via Slack earlier, he confirmed things worked as expected in WP 6.7.2 and 6.8.1 so it sounds more like issues within our e2e tests/config. I wouldn't be surprised if it was a UI change in Gutenberg that's impacting things, so probably worth checking the Cypress test artifacts to see what's off and then trying to account for that in adjusted e2e tests.
@10up/open-source-practice anyone able to help stabilize the e2e tests so we can comfortably bump the WP tested-up-to 6.8 here?
@10up/open-source-practice anyone able to help stabilize the e2e tests so we can comfortably bump the WP tested-up-to 6.8 here?
Looking at this again, the tests are failing when trying to access/use the environment variables MICROSOFT_AZURE_ACCOUNT_NAME and MICROSOFT_AZURE_ACCOUNT_KEY so seems like those may still not be set properly.
The error we are getting is cy.type() can only accept a string or number. You passed in: undefined. Running those tests locally works as long as I set those environment variables so I think we just need to ensure those values are properly set and not empty
Ah, reviewed another PR and the E2E tests were passing which seemed weird they would pass there but not here. Looking at this again, the issue here is this PR comes from a fork, which won't have access to our secrets and thus tests will not pass. So I think we're good to merge this in