simple-local-avatars icon indicating copy to clipboard operation
simple-local-avatars copied to clipboard

Published 20 hours ago • verified publisher icon 10up

PHP warnings due to wrong param type

Open dkotter opened this issue 2 years ago • 2 comments

Describe the bug

As reported on WordPress.org, seems there's some situations that can result in PHP warnings. I have not been able to reproduce myself but in looking at the code, I think we can add a couple checks here to easily suppress these warnings.

Steps to Reproduce

See https://wordpress.org/support/topic/error-during-authorization-to-rocketchat/

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

dkotter avatar Jul 28 '23 16:07 dkotter

Maybe we can close https://github.com/10up/simple-local-avatars/issues/220 in favor of this if they're related?

vikrampm1 avatar Jul 31 '23 05:07 vikrampm1

Maybe we can close #220 in favor of this if they're related?

No, these are different issues. #220 is about adding PHP version checks whereas this issue is about some users getting PHP warnings

dkotter avatar Jul 31 '23 15:07 dkotter