distributor icon indicating copy to clipboard operation
distributor copied to clipboard
verified publisher icon 10up

Add view all post types filter to External Connections.

Open ankitrox opened this issue 2 years ago • 5 comments

Description of the Change

Introduce a "View All" post type view to the pull screen for external connections for parity with the internal connections. The new view is the default when visiting Distributor > Pull Content > [External connection].

Closes #861

How to test the Change

  1. Create two separate sites using insta wp.
  2. Install distributor plugin on both the sites. Connect the sites.
  3. Create a custom post type "Book" on both the sites.
  4. On pull screen ensure that "View All" option is available.
  5. Pull content from CPT and it should pull the posts from external sites.

Changelog Entry

Added - Introduce "View all" post type view when pulling content from external connections.

Credits

Props @ankitrox, @Sidsector9, @ravinderk, @jeffpaul, @peterwilsoncc

Checklist:

  • [x] I agree to follow this project's Code of Conduct.
  • [x] I have updated the documentation accordingly.
  • [x] I have added tests to cover my change.
  • [x] All new and existing tests pass.

ankitrox avatar Jan 12 '23 18:01 ankitrox

Tagging Max on this one as he's already reviewed a separate PR #1002 for the same issue, so worth checking here to see which approach is most optimal (and can close the lessor of the two)

jeffpaul avatar Feb 06 '23 17:02 jeffpaul

@ankitrox can you please fill up the description and testing instructions for clarity?

Sidsector9 avatar Apr 24 '23 09:04 Sidsector9

@ankitrox can you please fill up the description and testing instructions for clarity?

Added the steps to test

ankitrox avatar May 05 '23 12:05 ankitrox

The changes in develop to the includes/rest-api.php file are causing a few conflicts for this.

However, the good news is that the changes allow for requesting any as the post type to get all the post types so you won't need to make any changes to the file -- the other files will need to specify the post type as any rather than all.

peterwilsoncc avatar Jul 21 '23 00:07 peterwilsoncc

@ankitrox thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

github-actions[bot] avatar Apr 15 '24 23:04 github-actions[bot]

Closing in favor of #1002.

jeffpaul avatar Jul 05 '24 13:07 jeffpaul