classifai icon indicating copy to clipboard operation
classifai copied to clipboard

Published 20 hours ago • verified publisher icon 10up

upkeep/670: Add utility to migrate settings

Open Sidsector9 opened this issue 1 year ago • 3 comments

Description of the Change

PR adds migration script to migrate existing configured settings to new feature first settings introduced in classifAI v3.

Closes #670

How to test the Change

  1. Clone this repo
  2. Checkout to trunk branch, and build the plugin files
  3. Activate the plugin and configure all of the AI providers.
  4. Checkout to this PR branch. upkeep/670
  5. Verify that you see the notice about ClassifiAI settings migrated and changes in v3
  6. Go to Tools > ClassifAI and make sure all settings migrated properly.
  7. Validate each features are working properly.

Changelog Entry

Added - Tool to migrate feature settings from versions < 3.0.0

Credits

Props @dkotter @Sidsector9 @iamdharmesh

Checklist:

  • [x] I agree to follow this project's Code of Conduct.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my change.
  • [ ] All new and existing tests pass.

Sidsector9 avatar Feb 12 '24 13:02 Sidsector9

@Sidsector9 thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

github-actions[bot] avatar Feb 12 '24 13:02 github-actions[bot]

Note: E2E tests are failing due to some issue in wp-env.

iamdharmesh avatar Feb 21 '24 13:02 iamdharmesh

QA Update ⚠️

@iamdharmesh Thanks for the PR.

I have checked migration with branch upkeep/670 and I'm getting some issue with migration.

I tried the same steps mentioned in the PR description and noticed that sometimes the migration is not working as expected.

Please check the video below, and let me know if you need any help to reproduce the issue.

Issue video: https://drive.google.com/file/d/1YTHY4U0qRHKRnqH6kcpLnGdLbQo_3WxV/view?usp=drive_link

qasumitbagthariya avatar Feb 26 '24 05:02 qasumitbagthariya

One other thing to consider is we aren't deleting any of the old settings that are stored in options. I think that's okay for now, as it allows users to access that if something does go wrong in the migration process. But we probably want to look at cleaning that up in a release or two.

dkotter avatar Feb 27 '24 23:02 dkotter