WP-Minions icon indicating copy to clipboard operation
WP-Minions copied to clipboard

Added shutdown_hook_priority to rabbitmq_server

Open stijnjanmaat opened this issue 5 years ago • 3 comments

Description of the Change

When you have multiple actions taking place on the wp hook shutdown, you want to be able to postpone the shutdown of the Connection to RabbtiMQ. That's why I expanded the $rabbitmq_server config with shutdown_hook_priority.

Alternate Designs

Thought about setting the hook hard coded to PHP_INT_MAX but making it configurable is more flexible.

Benefits

You have more finegrained control of when the Connection is destroyed.

Possible Drawbacks

Maybe a bit more complex, but default behavior is unchanged.

Verification Process

I implemented fork in my project and it worked.

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [x] My code follows the code style of this project.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my change.
  • [x] All new and existing tests passed.

Applicable Issues

Changelog Entry

stijnjanmaat avatar Feb 19 '20 14:02 stijnjanmaat