ElasticPress icon indicating copy to clipboard operation
ElasticPress copied to clipboard

Limit WooCommerce integration with ability to allow it

Open MARQAS opened this issue 2 years ago • 2 comments

Description of the Change

Filter to allow WooCommerce. It will limit the usage of WooCommerce integration to the places where it is actually needed.

Closes #2809

How to test the Change

Changelog Entry

Added - Filter to allow/limit WooCommerce integration Changed - should_integrate_with_query function

Credits

Props @MARQAS

Checklist:

  • [x] I agree to follow this project's Code of Conduct.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my change.
  • [ ] All new and existing tests pass.

MARQAS avatar Aug 01 '22 18:08 MARQAS

@MARQAS before we merge this one we will need a list of real scenarios where we would expect the feature to integrate or not with Elasticsearch. Then that will need to become proper tests. Can you please work on that? Thanks.

felipeelia avatar Aug 24 '22 16:08 felipeelia

https://github.com/10up/ElasticPress/pull/2914/commits/f66b88011ac471fd8fa013025024fc641626b443 looks good but am not sure if the two instances of ep_integrate removed from tests is all we need. Did we create the list of scenarios @MARQAS ?

oscarssanchez avatar Sep 19 '22 22:09 oscarssanchez

@MARQAS I've created a new sheet in our doc with a format I think will make things easier for us to understand. Can you please let me know when you have that completely filled? Feel free to add any new lines/scenarios you think I missed. After we have that complete, we can plan to write tests for each scenario. Thanks!

felipeelia avatar Oct 12 '22 13:10 felipeelia

Closing this in favor of (the already merged) #3259

felipeelia avatar Feb 24 '23 14:02 felipeelia