Results 77 comments of 10gic

I performed the same test using two different versions (4.1.7/4.2.0-dev-rc2) and found that the new version(4.2.0-dev-rc2) is much better. However, the memory consumption keeps increasing with the number of PublicKey/AnyAddress....

Hi @vcoolish, do you have any idea why the memory consumption is still increasing in the test case above after the fix?

> Hi @10gic, could you please clarify which WalletCore package do you use? `com.trustwallet.wallet-core (maven)` or `com.trustwallet.wallet-core-kotlin-jvm (maven)` or `com.trustwallet.wallet-core-kotlin-android (maven)`? Hi @satoshiotomakan, I used `wallet-core-kotlin-android` in previous tests.

> > Hi @vcoolish, do you have any idea why the memory consumption is still increasing in the test case above after the fix? > > could you try adding...

> > > > Hi @vcoolish, do you have any idea why the memory consumption is still increasing in the test case above after the fix? > > > >...

Hi @vcoolish, I have retested wallet-core-kotlin-android:4.2.0-dev-rc2 with a 1ms delay in each iteration. Here are the results: The native memory usage keeps increasing and has reached up to 200.1MB (almost...

Hi @vcoolish, I noticed that the code changes in PR https://github.com/trustwallet/wallet-core/pull/4070 are not included in version wallet-core-kotlin-android:4.2.0-dev-rc2. Could PR https://github.com/trustwallet/wallet-core/pull/4070 have resolved this memory leak issue?

@satoshiotomakan Thanks for your debugging. May I ask if there's a plan for when the dev branch can be merged into the master branch?

Hi @satoshiotomakan, is it possible to merge the PR into the master branch in January 2025? Merry Christmas 🎄.

Fixed in RP https://github.com/trustwallet/wallet-core/pull/4037 and https://github.com/trustwallet/wallet-core/pull/4092