100ms-react-native icon indicating copy to clipboard operation
100ms-react-native copied to clipboard

fixed react native 81 sdk compatibility issues

Open theafolayan opened this issue 2 months ago • 4 comments

This pull request updates the React Native HMS Android module to improve compatibility with React Native 0.81 by ensuring that event and command maps are returned as MutableMap instances. It also refactors the usage of the current activity throughout HMSManager to consistently use reactApplicationContext.currentActivity, which is a more reliable way to access the current activity in React Native modules.

React Native 0.81 compatibility improvements

  • Updated getExportedCustomDirectEventTypeConstants, getExportedCustomBubblingEventTypeConstants, and getCommandsMap in HMSHLSPlayerManager and HMSSDKViewManager to wrap maps with HashMap, ensuring the returned type matches the expected MutableMap signature for React Native 0.81. [1] [2] [3] [4] [5]

Activity access refactoring

  • Replaced all instances of currentActivity with reactApplicationContext.currentActivity in HMSManager, making activity access more robust and preventing potential null pointer issues. This change affects PIP registration, screenshare, audioshare, and lifecycle callback registration/unregistration. [1] [2] [3] [4] [5] [6] [7] [8] [9]

theafolayan avatar Nov 06 '25 18:11 theafolayan

Merging to main in this repository is managed by Trunk.

  • [ ] To merge this pull request, check the box to the left or comment /trunk merge below.

trunk-io[bot] avatar Nov 06 '25 18:11 trunk-io[bot]

An error occurred while submitting your PR to the queue: Only users that are a part of this repo's Trunk organization or have write permissions to the repo can submit a PR to the queue

trunk-io[bot] avatar Nov 06 '25 18:11 trunk-io[bot]

@gzerad @s-dvd This is costing our Business Money!!

theafolayan avatar Nov 27 '25 13:11 theafolayan

@ygit , please look into this and approve so we can have access to the FIX!

We're a paying customer FGS and you're all acting non-challant while we have to scramble for solutions.

theafolayan avatar Nov 27 '25 13:11 theafolayan

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Jan 12 '26 02:01 github-actions[bot]