VocableTrainer-Android icon indicating copy to clipboard operation
VocableTrainer-Android copied to clipboard

Activity memory leak caused by anonymous threads

Open cuixiaoyiyi opened this issue 3 years ago • 1 comments

Possible Memory Leak

An anonymous inner class will hold a reference to the this pointer of the outer class and will not be released until the thread ends. It will hold the Activity and prevent its timely release. Please check the links below.

Occurrences

https://github.com/0xpr03/VocableTrainer-Android/blob/master/app/src/main/java/vocabletrainer/heinecke/aron/vocabletrainer/activity/MainActivity.java#L89

Possible Solution

If it is necessary, it can be changed to static class + weak reference to eliminate the reference to the activity, which may cause memory leaks. Further discussion is welcome.

cuixiaoyiyi avatar Aug 31 '22 08:08 cuixiaoyiyi

Thanks, didn't know about that

0xpr03 avatar Aug 31 '22 11:08 0xpr03