vextab icon indicating copy to clipboard operation
vextab copied to clipboard

provide vextab via npm install & require('vetab')

Open timaschew opened this issue 10 years ago • 12 comments

This issue come from here: https://github.com/0xfe/vextab/issues/53#issuecomment-65061357

The next goal should be to support other module loader, as I explained here via a UMD: https://github.com/0xfe/vextab/issues/53#issuecomment-64485026

timaschew avatar Dec 05 '14 12:12 timaschew

Working on it. :-)

0xfe avatar Dec 05 '14 19:12 0xfe

Okay fine :) poke me if you need help

timaschew avatar Dec 05 '14 20:12 timaschew

Will do. Thanks.

-- sent frm fone On Dec 5, 2014 3:11 PM, "Anton Wilhelm" [email protected] wrote:

Okay fine :) poke me if you need help

— Reply to this email directly or view it on GitHub https://github.com/0xfe/vextab/issues/55#issuecomment-65847300.

0xfe avatar Dec 05 '14 20:12 0xfe

I tried to require vextab via npm, but it doesn't work, because of this line: https://github.com/0xfe/vextab/commit/ff5877ad23b8dfe7fe9bfe60b2b6fe37f96f7c69#diff-35f81cb6401704ff630d0f1f39a22707R11

And currently it only works if you use browserify, it would be work with any tool, if you add a prepublish step for npm and publish the js files instead of the coffee files.

timaschew avatar Mar 07 '15 23:03 timaschew

I can do PR with a fix. would you like the solution to use a prepublish step to provide vextab as javascript via npm?

timaschew avatar Mar 10 '15 08:03 timaschew

I'm out of town till Apr 2nd. Will take a look when I'm back.

-- sent frm fone On Mar 10, 2015 2:08 PM, "Anton Wilhelm" [email protected] wrote:

should a make a PR to fix it? would you like the solution to use a prepublish step to provide vextab as javascript via npm?

— Reply to this email directly or view it on GitHub https://github.com/0xfe/vextab/issues/55#issuecomment-78013782.

0xfe avatar Mar 10 '15 09:03 0xfe

@0xfe hi, what is the status of this? I'd like to send you PR with js build, so you can publish pure JS module to npm, but I am not able to run tests from master, i have basically this problem: https://travis-ci.org/0xfe/vextab/builds/157201147

vojty avatar Feb 01 '17 20:02 vojty

Same here, requiring vextab requires something that understands coffeescript, as a workaround I just included vextab-div seperate from my bundle...

hrgui avatar Feb 05 '17 05:02 hrgui

@hrgui I have prepared PR https://github.com/0xfe/vextab/pull/90 with commonjs build

vojty avatar Feb 05 '17 10:02 vojty

@vojty what's about this?

SalahAdDin avatar Feb 25 '17 21:02 SalahAdDin

@SalahAdDin well my PR is almost mergeable, but I need help with tests. Current master branch has some issues https://github.com/0xfe/vextab/pull/92 maybe @0xfe could help...

vojty avatar Feb 26 '17 15:02 vojty

@0xfe @vojty I think he could.

SalahAdDin avatar Feb 27 '17 13:02 SalahAdDin