Glenn 'devalias' Grant
Glenn 'devalias' Grant
I believe this PR by @j4k0xb will also technically resolve this issue; though I wonder if it would be better UX to detect the empty file earlier on at the...
> An empty file is valid JavaScript so there shouldn't be any warning/error imo. @j4k0xb I'm specifically talking about the human focussed error/warning when running this against an empty starting...
> But still not a fan of skipping files... @j4k0xb I guess that really depends where 'skipping' is implemented. The hacky workaround in `unminify` ([Ref](https://github.com/jehna/humanify/issues/54#issuecomment-2378111141)) was never suggested as a...
> I'm specifically talking about the human focussed error/warning when running this against an empty starting file, and providing better feedback to the user around that. In addition to the...
> The hacky workaround in `unminify` ([Ref](https://github.com/jehna/humanify/issues/54#issuecomment-2378111141)) was never suggested as a proper fix to this, it was only a hacky workaround, as I said at the bottom of it:...
> This should be fixed now @jehna Fixed technically, but see notes above in https://github.com/jehna/humanify/issues/54#issuecomment-2412626831 + https://github.com/jehna/humanify/issues/54#issuecomment-2381073944 for why the way it was implemented may not have been the ideal...
See also: - https://github.com/jehna/humanify/issues/52 --- I don't think those deprecated packages are actually the source of your install failure here though; I think it's more related to `isolated-vm`. Are you...
> I wonder which place would be better. @jehna Does the `package.json` `engines` field enforce it? - https://docs.npmjs.com/cli/v10/configuring-npm/package-json#engines - > engines > You can specify the version of node that...
See also: - https://github.com/colinhacks/zod/discussions/2215#discussioncomment-5356276
> All the magic happens in `smallestScope.scope.rename(smallestScopeNode.name, safeRenamed);` @j4k0xb Hrmm, fair. Skimming through the logic: - `visitAllIdentifiers` - calls `babel`'s `parseAsync` to get the AST - creates `Set`'s for `renames`...