Cédric Luthi
Cédric Luthi
OK, let's take care of `PortForwardingContainer` in a follow up PR. I see that you removed the structured logging of runtime information that I had introduced. I re-introduced it in...
OK fine, I’ll revert. What about the empty `TestcontainersSettings` static constructor? > Happy to merge the pull request afterward and publish a beta version. Could you please have a look...
I just pushed 1bf2f9689197779419974c91fcf3d52bb9772a3c which removes the structure logging and I extracted the logging code into a new method for improved readability, and also catching only the exceptions when running...
Good point! Done in 34f3c2d6c8ed3e34242f0516d003c1a3308b7e50.
Discussion on the .NET runtime repository for reference: [Introduce DbDataSource abstraction to System.Data](https://github.com/dotnet/runtime/issues/64812)
Well, it looks like running Firebird in a docker container on AppVeyor is [not as easy](https://help.appveyor.com/discussions/problems/25465-pipedocker_engine-access-denied) as it ought to be. 😣 [Downloading and configuring and running](https://github.com/nhibernate/nhibernate-core/blob/90d50c03475628d10336cbad368f071375056fef/appveyor.yml#L42-L62) Firebird could also...
Unfortunately I'm not familiar enough with AppVeyor. There's this [//./pipe/docker_engine access denied?](https://help.appveyor.com/discussions/problems/25465-pipedocker_engine-access-denied) discussion on the AppVeyor forum but it doesn't seem to really offer a solution. Alternatively, Firebird could probably...
I think they could be internal but we would lose the ability to specify another ParserOptions with the `Register` method. Also, all the system type converter classes are public.
Will do next week when I'm back in front of a computer.
It's actually much worse, the dependency on `Newtonsoft.Json` is not properly declared in the NuGet package. I was trying to replace `Newtonsoft.Json` with `System.Text.Json` in [Stryker.NET][1] and the dependency on...