Kaku icon indicating copy to clipboard operation
Kaku copied to clipboard

Hiragana-only words do not show up in the dictionary

Open SpongebobSquamirez opened this issue 5 years ago • 8 comments

ぼうし(帽子)、けわしい(険しい)、うわさ(噂), and conjugated hiragana words can't be selected/aren't detected in the results window. I'm guessing if there's a kanji form, even if the kana form is common enough that it's written in kana in books for kids (as opposed to written in 漢字+振りがな), it won't be found in the dictionary.

SpongebobSquamirez avatar Mar 04 '19 05:03 SpongebobSquamirez

Just wanted to say that this is still a big issue for me. Seems like it never works. Was it supposed to work sometimes? I guess if a word has any associated kanzi, it just won't work. Also seems to affect different ways of writing the same word, eg compound verbals like いい表す (言い表す).

SpongebobSquamirez avatar Apr 23 '19 12:04 SpongebobSquamirez

I been pretty busy IRL the past month so haven't really had time to work on Kaku, unfortunately.

Hiragana lookups currently only work if the entry itself is in the dictionary character-for-character, which is often not the case. Supporting this requires rewriting the dictionary lookup logic since the current implementation is a pretty dumb one.

0xbad1d3a5 avatar Apr 24 '19 09:04 0xbad1d3a5

Okay, thanks for letting me know. Just want to say that after consistent use of the app for months now, this is by far the issue that ends up costing me the most time, since it seems like half the time I look something up, this can't find the entry. If you find some time to work on the app in the near future, I think this is the most pressing issue.

SpongebobSquamirez avatar May 18 '19 07:05 SpongebobSquamirez

I know you're probably dead but since I still use this app all the time, and this is still the only thing that annoys the hell out of me about this app, and there don't seem to be any alternatives, I'm just gonna bump this in the off chance that you see this at some point and remember how much potential this thing has.

SpongebobSquamirez avatar Feb 03 '20 05:02 SpongebobSquamirez

I agree, everything else is not a big deal. Is there any way we can get more coverage to this app and someone can add it in maybe.

p734 avatar Feb 07 '20 22:02 p734

I ported over Nazeka's search logic: https://github.com/dtan3847/Kaku These examples work: ぼうし(帽子)、けわしい(険しい)、うわさ(噂) This example does not (it doesn't work in Nazeka): いい表す

There are still problems (for example, right now all of the entries are loaded into memory) and maybe I'll have time to improve it later.

dtan3847 avatar Aug 06 '21 07:08 dtan3847

Oh wow, you're a hero @dtan3847 haha.

0xbad1d3a5 avatar Aug 06 '21 11:08 0xbad1d3a5

Hey all, I made a new database that basically fixes this by adding dictionary entries for kana readings. You can get it from my PR (above), then download the FDroid APK, open it with 7zip, replace the database (in assets folder), then re-sign and install the APK to use it. Or just download this APK here if you trust me =)

Artikash avatar Jun 11 '22 05:06 Artikash