Wesley de Groot comments

Results 69 comments of


                                            Wesley de Groot

Updated for Swift 5

I've append your patch at https://github.com/wdg/CodeEditor

🐞 ? Changes to File not persisted

`CodeEditor.didBeginEditing` is used to determine that the document is/was changed (for keeping the tab open). If there are no changes, the tab will be switched to the newly opened file....

🐞 `.h` extension as a default when saving files

Was your last opened file a `.h` file? normally it uses the extension of the last opened file.

Settings Search

@luah5 can you fix the conflict with `CodeEdit.xcodeproj/project.pbxproj`? Then it should be fine for re-review.

@luah5 FYI, `shorthand_operator` should not trigger if you use `Text() + Text()`. see https://github.com/realm/SwiftLint/issues/4936, https://github.com/realm/SwiftLint/issues/4953 for more information.

✨ Icons for every file format and file format opacity

> @austincondiff Could you assign this to me? I'm not Austin, but here we go :)

🧹 Improvements to SwiftLint

I'm not really a fan of `implicit_return`, IMHO it makes it more difficult for starters to know when or when not to use a return. However we should definitely discourage...

✨ Text selection with round corners

i think if we implement this feature, it needs to be disabled by default. See this stack overflow post, it might help https://stackoverflow.com/questions/16362407/nsattributedstring-background-color-and-rounded-corners

Gutter view flickers and changes width oddly when resizing

We don't use this gutter system anymore, therefore i close this issue. if you keep encountering it, then please add a comment and we'll reopen the issue.

Switching Windows doesn't change Active Editor

Thanks haven't noticed it because I never move tabs 😊