Tim Condon comments

Results 601 comments of


                                            Tim Condon

Provide a current user home directory API in FileSystem

Nothing really blocking at the moment, workaround is either read `$HOME` or just use the `FileManager` API

Support HTTP/2

@Sherlouk this is parity of an existing functionality, but #3205 is still being tracked for the Vapor 5 release. Realistically this will fall outside of Vapor when #3376 is implemented...

Fix `request.body.data` becomes nil instead of empty when the request body is empty

I don't actually think this is the right approach as it could have unintended consequences for other decoders. Especially JSON - that should fail without a body. I think this...

Fix `request.body.data` becomes nil instead of empty when the request body is empty

@sidepelican I did and my point still stands. This needs to be fixed at the FormDataDeocder level, not in the request body

Fix `request.body.data` becomes nil instead of empty when the request body is empty

This would be a major break, removing automatic error handling and unprocessible responses in existing code. What we probably need to do is have a look up one decoders to...

Fix `request.body.data` becomes nil instead of empty when the request body is empty

@sidepelican Where did you hit this bug? Because I'm trying to dig through the URI/HTTP spec to ensure that no body is actually valid (as opposed to an empty body)

Fix `request.body.data` becomes nil instead of empty when the request body is empty

Ok I see what you mean. I think right now, especially Vapor 4, this probably just falls underneath unsupported behaviour. The spec isn't very clear about whether no body is...

Cookie Partitioned property

@tikiram Yep feel free to submit a PR to add support!

VaporTesting cannot be built

Do you have Xcode installed?

VaporTesting cannot be built

This is probably an issue for the Swiftly folks