starknet-devnet-rs icon indicating copy to clipboard operation
starknet-devnet-rs copied to clipboard

Breaking: Rename gas price parameters - only strk/fri

Open FabijanC opened this issue 7 months ago • 4 comments

Usage related changes

  • Closes #771

Development related changes

Checklist:

  • [ ] Checked out the contribution guidelines
  • [ ] Applied formatting - ./scripts/format.sh
  • [ ] No linter errors - ./scripts/clippy_check.sh
  • [ ] No unused dependencies - ./scripts/check_unused_deps.sh
  • [ ] No spelling errors - ./scripts/check_spelling.sh
  • [ ] Performed code self-review
  • [ ] Rebased to the latest commit of the target branch (or merged it into my branch)
    • Once you make the PR reviewable, please avoid force-pushing
  • [ ] Updated the docs if needed - ./website/README.md
  • [ ] Linked the issues resolvable by this PR - linking info
  • [ ] Updated the tests if needed; all passing - execution info

Summary by CodeRabbit

  • New Features

    • Simplified gas price configuration by consolidating multiple gas price parameters into three unified fields: l1_gas_price, l1_data_gas_price, and l2_gas_price.
  • Refactor

    • Updated all CLI flags, environment variables, API schemas, and configuration files to use the new unified gas price fields.
    • Adjusted test setups and helper utilities to align with the new gas price representation.
  • Documentation

    • Revised API schema documentation to reflect the consolidated gas price fields and removed references to deprecated parameters.

FabijanC avatar May 13 '25 11:05 FabijanC

[!IMPORTANT]

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This change refactors the handling of gas price parameters throughout the codebase. It consolidates previously separate gas price fields—distinguished by "wei" and "fri" units for L1 gas price, L1 data gas price, and L2 gas price—into three unified fields: l1_gas_price, l1_data_gas_price, and l2_gas_price, all denominated in FRI units. The update affects configuration structs, CLI argument parsing, block and transaction logic, test setups, and API schemas. Methods and data structures are updated to use the new unified fields, and related test cases, documentation, and API definitions are modified to match the new naming and structure. No changes to control flow or error handling are introduced.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 13 '25 11:05 coderabbitai[bot]

@coderabbitai review

FabijanC avatar May 13 '25 11:05 FabijanC

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai[bot] avatar May 13 '25 11:05 coderabbitai[bot]

Looks like -wei prices might be necessary after all: L1->L2 messages require them, as discussed on Slack.

FabijanC avatar May 22 '25 09:05 FabijanC