starknet-devnet-rs icon indicating copy to clipboard operation
starknet-devnet-rs copied to clipboard

Published 20 hours ago • verified publisher icon 0xSpaceShard

Update OpenZeppelin contracts to 0.9.0

Open mikiw opened this issue 1 year ago • 5 comments

https://github.com/OpenZeppelin/cairo-contracts/blob/v0.9.0/src/token/erc20/erc20.cairo

remember about removing the #[key] keyword from the event in erc20 contracts so it is not indexed (related to https://github.com/0xSpaceShard/starknet-devnet-rs/pull/356)

mikiw avatar Feb 19 '24 09:02 mikiw

Seems that the current OZ wizard doesn't support the mintable feature for v0.9.0.

Due to this problem and the urgency of key attribute comments, this will need to be handled in 2 separate PRs.

Changing status to on hold.

mikiw avatar Feb 21 '24 14:02 mikiw

Perhaps UDC can also be updated with this issue

FabijanC avatar Mar 28 '24 12:03 FabijanC

v0.11 came out in the meantime!

ivpavici avatar Apr 08 '24 10:04 ivpavici

v0.13 is out: https://github.com/OpenZeppelin/cairo-contracts/releases/tag/v0.13.0

FabijanC avatar May 20 '24 16:05 FabijanC

Seems that the update of UDC requires a version of starknet.rs that supports the selector "deploy_contract" (0.13.0 cairo1) instead of "deployContract" (0.5.0 cairo0)

https://github.com/xJonathanLEI/starknet-rs/blob/36ec1d681fc2917ca4857d14ce262ed7c2b60a7a/starknet-contract/src/factory.rs#L16

mikiw avatar Jun 19 '24 12:06 mikiw

As discussed here: https://spaceshard.slack.com/archives/C029F9AN8LX/p1738944026864319 We need an account contract implementation which doesn't use unwrap, but unwrap_syscall. One more reason to address this issue.

FabijanC avatar Feb 10 '25 15:02 FabijanC