Block hash computation

[marioiordanov]

Check the implementation of Madara project for computing the block hash.

[ivpavici]

Our hash calculation is different than on testnet / Madara. It is probably not relevant for users, but can be improved potentially to be the same

[0xibs]

Hi @ivpavici, what is the call to action here please? I would like to hop on it.

[0xibs]

Hi @ivpavici, still anticipating your reply. Thanks

[RajeshRk18]

Can I work on this?

[0xibs]

@marioiordanov Please can you add more context to this issue? Am I reimplementing the function for computing block hash?

[0xibs]

And also going through the development docs linked in the README, I found this warning Is it still safe to use it? @marioiordanov @ivpavici

[marioiordanov]

As you can see the generate_hash of StarknetBlock contains mostly dummy values. The idea is to make it similar to mainnet

[0xibs]

@marioiordanov this is the closest I could find to compute block hash in Madara project: https://github.com/keep-starknet-strange/madara/blob/main/crates/primitives/block/src/header.rs#L85

Please kindly confirm if that is what I am supposed to look into.

[marioiordanov]

yes

[0xibs]

And also going through the development docs linked in the README, I found this warning Is it still safe to use it? @marioiordanov @ivpavici

@marioiordanov @ivpavici kindly see this please. It's a blocker for me.

[ivpavici]

And also going through the development docs linked in the README, I found this warning Is it still safe to use it? @marioiordanov @ivpavici

@marioiordanov @ivpavici kindly see this please. It's a blocker for me.

Not sure what you mean about the warning? Why is it a blocker? It is a message from the old devnet, not devnet-rs

[marioiordanov]

Probably this issue is not of a such importance, because:

• devnet doesn't have the hashes of the events, which are needed for producing the correct block hash.
• users using devnet dont compare the block hash to the hash generated on testnet/mainnet