miden-vm icon indicating copy to clipboard operation
miden-vm copied to clipboard

Change type of `clk` to u32

Open grjte opened this issue 2 years ago • 2 comments

Comment for the future: we frequently use u64 or usize for clk - but in our field, clk is guaranteed never to exceed a u32 value. I wonder if some point we should go through and update it everywhere to u32.

Originally posted by @bobbinth in https://github.com/maticnetwork/miden/pull/304#discussion_r919642358

grjte avatar Jul 13 '22 16:07 grjte

Can you assign me to it? It looks like I cannot do it myself.

Dominik1999 avatar Aug 01 '22 12:08 Dominik1999

Sure, it's yours. Thanks!

grjte avatar Aug 01 '22 22:08 grjte

Just a note that for changes to the handling of the stack overflow table described in #347 the type won't be able to change to u32 in the stack module in the processor, so that one can be skipped.

If some changes are required in order to get all other changes in the codebase to compile, that will be fine - just keep it as minimal as possible, and I'll adjust the rest as I implement #347.

grjte avatar Aug 24 '22 15:08 grjte

Closed by #376.

bobbinth avatar Sep 08 '22 20:09 bobbinth