miden-vm icon indicating copy to clipboard operation
miden-vm copied to clipboard

[fix]: VerifyCmd Flag Collision

Open varun-doshi opened this issue 5 months ago • 0 comments

Describe your changes

Related https://github.com/0xPolygonMiden/miden-vm/issues/1421

This PR does the following:

  • Updates the symbol for program-hash to -x. No long form
  • Creates an infer_defaults function which checks the directory specified by the input file passed(with -i) to search for a .proof and .outputs file (only if these files are not already specified) . If these files are already specified by user, then it does not run this check. Hence the command can be called as such:
./target/optimized/miden verify -i PATH_TO_INPUT_FILE.inputs -x PROGRAM_HASH -o PATH_TO_OUTPUT_FILE.outputs -p PATH_TO_PROOF_FILE.proof

as well as such:

./target/optimized/miden verify -i PATH_TO_INPUT_FILE.inputs -x PROGRAM_HASH 

TODO:

  • [ ] Update docs

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

varun-doshi avatar Sep 26 '24 06:09 varun-doshi