polygon-edge icon indicating copy to clipboard operation
polygon-edge copied to clipboard

Migrate polybft e2e framework to edge

Open vcastellm opened this issue 2 years ago • 3 comments

Description

Please provide a detailed description of what was done in this PR

Changes include

  • [ ] Bugfix (non-breaking change that solves an issue)
  • [ ] Hotfix (change that solves an urgent issue, and requires immediate attention)
  • [x] New feature (non-breaking change that adds functionality)
  • [ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • [x] I have assigned this PR to myself
  • [x] I have added at least 1 reviewer
  • [x] I have added the relevant labels
  • [x] I have updated the official documentation
  • [x] I have added sufficient documentation in code

Testing

  • [x] I have tested this code with the official test suite
  • [x] I have tested this code manually

Manual tests

Running in local

vcastellm avatar Oct 13 '22 14:10 vcastellm

Codecov Report

:exclamation: No coverage uploaded for pull request base (feature/v3-parity@d5ff74c). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head b7b8af3 differs from pull request most recent head 92dcc55. Consider uploading reports for the commit 92dcc55 to get more accurate results

@@                 Coverage Diff                  @@
##             feature/v3-parity     #797   +/-   ##
====================================================
  Coverage                     ?   46.48%           
====================================================
  Files                        ?      157           
  Lines                        ?    20803           
  Branches                     ?        0           
====================================================
  Hits                         ?     9670           
  Misses                       ?    10430           
  Partials                     ?      703           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Oct 14 '22 13:10 codecov[bot]

Generally looks good, but not sure if we should strive to consolidate existing edge framework with this one somewhere in the future?

Yeah, this should be our goal, but it will be out of the scope in this PR, we still have some work to do, but anyway, the existing e2e framework in edge is going to be removed at some point.

And just not to forget: we need to port bridge test (and bridge e2e testing framework infrastructure).

Same here, pending to do.

vcastellm avatar Oct 18 '22 13:10 vcastellm

Snyk tests are about some outdated dependencies we have in general across the repo, we'll need to address them in following PRs

vcastellm avatar Oct 19 '22 09:10 vcastellm