polygon-edge icon indicating copy to clipboard operation
polygon-edge copied to clipboard

enableDataDogProfiler() err check is wrong

Open R-Santev opened this issue 1 year ago • 1 comments

enableDataDogProfiler() err check is wrong

Description

A wrong variable is checked for error is made in server/server.go:175 image

Your environment

  • OS and version. Irrelevant.
  • The version of the Polygon Edge.
    Version 1.3.3
  • The branch that causes this issue. develop
  • Locally or Cloud hosted (which provider). Irrelevant.
  • Please confirm if the validators are running under containerized environment (K8s, Docker, etc.). Irrelevant.

Expected behavior

  • Tell us what should happen. " DataDog profiler setup failed" must be logged when ddErr is != nil
  • Tell us what happened instead. It doesn't enter the if statement

Proposed solution

I am attaching a PR resolving the issue: https://github.com/0xPolygon/polygon-edge/pull/2200

R-Santev avatar Aug 02 '24 16:08 R-Santev