Dongpo Liu

Results 270 comments of Dongpo Liu

@hds Do you have time to take a quick look at this pull request before I continue? I want to ensure I'm on the right track and understand your feedback...

> To integrate this with Tokio-Console, I would get the `State` stream from `WatchState` and include it in the `tokio::select!` statement in `main()`: The issue at hand is that when...

@hds, I finally have some time to fix it. Could you please take a look? Thank you!

Rebaed to the latest master.

Thanks for your review! 💚 💙 💜 💛 ❤️

@l0calh05t Friendly ping~ Do you have time to update the tests then we can move forward with this PR? Thanks!

> FWIW I'm not sure whether we should add this to the existing yank API (`DELETE /api/v1/crates/:crate_id/:version/yank` and `PUT /api/v1/crates/:crate_id/:version/unyank`). I kind of agree with this because we don't actually...

Because this API change could potentially introduce a new API to all registries, I want to summarize the current situation and specify the new API we want to add. ##...

> What is the plan for other "patch like" changes to a crate version? For example editing the "description" or "maintenance"? I only ask because the same argument would suggest...

> Separately, how should cargo determine when to use the new endpoint? This needs to be made explicit because it also applies to all other registries. This is a really...