Dongpo Liu

Results 274 comments of Dongpo Liu

I was too busy last week, but I will begin working on the design and implementation this week.

> I haven't seen this feature on other products and platforms. Do you have any examples we can refer to? GitHub has this feature, for instance: The UI looks like...

@hds Could you please help approve this PR? Then we can merge it. Thanks!

> It would be nice to avoid the MSRV bump --- is the `clap` dependency update necessary? As you can tell from the dependency tree: ```console ❯ cargo tree -i...

> There seem to be a lot of new transient dependencies added as part of this change. > > Is it possible to make the change without doing this? You...

> But I think we can split them into two PRs. But the change would be the same. Split: https://github.com/tokio-rs/console/pull/552

Thanks for your review! 💚 💙 💜 💛 ❤️

Thanks for your contribution! 🤟 🖤 This PR also involves very many changes that have nothing to do with trycmd. It's best to upgrade it separately rather than updating the...

What kind of content do we need to add?

Could you please provide more information about your environment? Or could provide a minimal project which can reproduce it.