rig icon indicating copy to clipboard operation
rig copied to clipboard

chore: Improved test assertion style for better readability

Open defiberrys opened this issue 11 months ago • 1 comments

I replaced assert!(expected == actual) with assert_eq!(expected, actual) in the test. While both work, assert_eq! is more idiomatic in Rust as it provides better output for debugging by automatically displaying the values when the assertion fails.

p.s. Change improves the readability and overall quality of the tests.

defiberrys avatar Feb 03 '25 19:02 defiberrys

Hello, thanks for this PR! This will not got merged until all of our CI passes. it also might be apt to rebase with main even if there are no conflicts, thanks!

There are also a lot of places where we could use assert_eq so perhaps this PR could handle that too!

0xMochan avatar Feb 12 '25 18:02 0xMochan

Closing because there has been no response from the PR author.

If you're still interested in opening another PR, you are free to do so!

joshua-mo-143 avatar Jun 19 '25 22:06 joshua-mo-143