upgrade-scripts icon indicating copy to clipboard operation
upgrade-scripts copied to clipboard

Published 20 hours ago • verified publisher icon 0xPhaze

fix(contracts): solve issue with foundry remappings

Open 0xGabi opened this issue 1 year ago • 2 comments

Hi, thank you for working on this. Super helpful when dealing with proxies and foundry!

Would like to propose this small update because since I upgrade to the latest nightly version of forge I started having this issue: https://github.com/foundry-rs/foundry/issues/3440.

0xGabi avatar Feb 19 '23 14:02 0xGabi

Hi Gabi, thanks for your interest and for reporting this. I can't reproduce the issue myself. Everything seems to be working as expected on the latest foundry version. Or perhaps I don't fully understand the issue.

Did you look into the discussion at

  • https://github.com/PaulRBerg/prb-math/issues/147

Do you have auto_detect_remappings = true in your foundry.toml? Can you maybe share a repository where this is an issue?

0xPhaze avatar Feb 20 '23 08:02 0xPhaze

Oh I didn't know about that config for foundry.toml. I just give it a try and it is still an issue for me 🤔

Here is the project were we are working with upgrade-scripts:

  • https://github.com/BlossomLabs/OsmoticFund/tree/controller-tests/pkg/contracts

Note that I update the submodule to point to our forked version: https://github.com/BlossomLabs/OsmoticFund/blob/controller-tests/.gitmodules#L17

0xGabi avatar Feb 20 '23 22:02 0xGabi