Felix Matouschek
Felix Matouschek
/remove-lifecycle stale
The tests fail because of a change introduced in #11962: 1. The Instancetype matcher is changed here (this PR): https://github.com/kubevirt/kubevirt/blob/736662f1b7734c00006bb7da92e28bcc8e503508/tests/hotplug/instancetype.go#L139 2. This always adds a RestartRequired condition if a matcher...
Updated to fix a nil-pointer access in `handleMemoryHotplugRequest`. See logs for panic: https://storage.googleapis.com/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/11455/pull-kubevirt-e2e-k8s-1.30-sig-compute-migrations/1795451827265736704/artifacts/k8s-reporter/pods/1_kubevirt_virt-controller-69b7c8c4b8-wpxbx-virt-controller.log
Missed another nil-pointer access in `handleMemoryHotplugRequest`, updated again. See https://storage.googleapis.com/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/11455/pull-kubevirt-e2e-k8s-1.30-sig-compute-migrations/1795490607427227648/artifacts/k8s-reporter/pods/1_kubevirt_virt-controller-5c6f74b5d5-6ht4x-virt-controller_previous.log
/retest-required
/test pull-kubevirt-e2e-k8s-1.30-sig-compute
I'm still not convinced we should put the revision names into the status of a VM. The spec is the desired state of a VM (including using a revision I...
@rmohr @davidvossel @vladikr @xpivarc @iholder101 Do you have an opinion on this?