Felix Matouschek
Felix Matouschek
/cc @brybacki /cc @xpivarc
No, because [`addDiskVolumeWithCloudInitNoCloud`](https://github.com/kubevirt/kubevirt/blob/28630a3f91434203f2eac3f4c5bce217e6a47833/tests/libvmi/cloudinit.go#L81) would have reused the existing `disk1` and would have overwritten/added the network configuration data.
A not so small and hopefully exhaustive list of failing tests: Overwriting / Reusing CloudInit config: ``` tests/credentials_test.go:219 tests/credentials_test.go:281 tests/migration_test.go:764 tests/migration_test.go:796 tests/migration_test.go:831 tests/migration_test.go:961 tests/migration_test.go:1025 tests/migration_test.go:1070 tests/migration_test.go:1125 tests/migration_test.go:1158 tests/network/expose.go:206 tests/network/expose.go:207 tests/network/expose.go:208...
@EdDev Overriding means not panicking and keeping the current behavior? I see it as a problem for example when you want to change the `bus` of an existing disk. That...
To be more specific, this is a test that runs into the changing the `bus` scenario. Instead of testing a `DiskBusUSB` disk, it actually tests with a `DiskBusVirtio` disk. https://github.com/kubevirt/kubevirt/blob/0f2c6714ae95371f14b34361f747c2311df18a4d/tests/migration_test.go#L1019...
As discussed previously another option would be to strictly panicking and avoiding any side-effects as initially introduced in this PR and to extended the libvmi API with a cleaner way...
@fabianvf Ping
@pmareke Thanks! Can you describe this in a little more detail? I'm not sure how you would change it. `__serialize` is called recursively on every `ResourceField` beginning with the root...
@pmareke Sorry, got it!