0xFable icon indicating copy to clipboard operation
0xFable copied to clipboard

Published 20 hours ago • verified publisher icon 0xFableOrg

Implement player handles

Open norswap opened this issue 1 year ago • 13 comments

Two key features:

  • resolve players ENS if they have one, use https://viem.sh/docs/ens/actions/getEnsName.html

  • Add a PlayerHandle contract where users can register a single handle for their address (they should be able to change it as well)

    • Handles should be unique
    • Add a checkHandleValidity function that restricts names (e.g. only ASCII, minimum 5 characters, maybe not contain dots (to avoid ENS / other name system clashes)
    • Add a checkPlayerEligibility that can be always true for now but down the line will only enable players that have completed some milestones (e.g. minimum amount of matches, minimum spend, ...) to register handles to avoid squatting.
    • If a user has an ENS, let them select whether they want to use their handle or their ENS.
    • Add an admin role that can be used later to avoid impersonation and squatting of popular names.

The frontend must be modified to display player handles (or ENS).

norswap avatar Feb 14 '24 17:02 norswap

can i hop on this?

faytey avatar Feb 15 '24 09:02 faytey

Go ham :)

norswap avatar Feb 15 '24 14:02 norswap

Thanks I'd work on this, for better context, I'd be writing a cairo contract to handle Player Ens/profile and updating the frontend showing their ens right?

faytey avatar Feb 19 '24 21:02 faytey

No, we're using Solidity on this game as we target an EVM rollup chain. Cairo contracts only work on Starknet.

norswap avatar Feb 21 '24 09:02 norswap

@faytey have you started working on this? I'd like to take this one if you change your mind and work on something else please.

saimeunt avatar Feb 22 '24 07:02 saimeunt

Just seeing this notification @saimeunt yes you can go ahead. @norswap I’d take up other issues thanks

faytey avatar Feb 22 '24 07:02 faytey

If this issue is still up, i would love to continue working on it @norswap

faytey avatar May 02 '24 15:05 faytey

Hey I'm no longer actively working on this feel free to pick it @faytey

saimeunt avatar May 02 '24 18:05 saimeunt

Hey I'm no longer actively working on this feel free to pick it @faytey

Cool, @norswap is this okay?

faytey avatar May 02 '24 21:05 faytey

Yes, go for it!

norswap avatar May 02 '24 22:05 norswap

Hi Sir @norswap I made a PR to this issue here 117 I need your review and comments sir.

faytey avatar May 20 '24 14:05 faytey

@norswap

Hi Sir @norswap I made a PR to this issue here 117 I need your review and comments sir.

faytey avatar May 21 '24 18:05 faytey

Sorry, things have been hectic these days. I will try to review this as soon as possible, but it might still take a few days!

norswap avatar May 30 '24 12:05 norswap